Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPDX-8224 - Remove the partner display name from certain areas to avoid confusion. #1079

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dr-bizz
Copy link
Contributor

@dr-bizz dr-bizz commented Sep 18, 2024

Description

In this PR, I fix the confusion around the Partner Account name.

Display Name changes based on what query you use.

Before, when loading the contact, the partner name would be one thing (As it was loading using the donation query), but when the contact query was loaded, it would change the partner account name to another.
Example:
The display name is Daffy and Daphney Duck (10308) when fetching the displayName via the donations query. But the displayName changes to Duck, Daffy and Daphney (10308) when I fetch it using the Contacts query.

I'm unsure if this is a backend issue or something we need to accommodate on the frontend.

Other changes I've made

If viewing the donation table outside of the contact detail page, it should show the display name. Example: Daffy and Daphney Duck (10308). But if it's inside the contact, it should just display the partner account number. example: 10308.

I have replaced the partner display name on the contact details header with just the partner number.

I have added the partner display name next to the partner number under the contact details tab in the partnership section.

Due to the cache updating the display name when loading the contact details query, I have moved the partnership query to a separate query and made it so it doesn't update the cache if a different display name returns.

Need to check

We need to check if the backend can ensure the partner display name can make it so the same name returns always no matter how you query (donations query or contact query). If the backend team does that. a lot of the work in this PR can be undone.

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

Copy link

Bundle sizes [mpdx-react]

Compared against bc5798e

No significant changes found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant