MPDX-8224 - Remove the partner display name from certain areas to avoid confusion. #1079
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, I fix the confusion around the Partner Account name.
Display Name changes based on what query you use.
Before, when loading the contact, the partner name would be one thing (As it was loading using the donation query), but when the contact query was loaded, it would change the partner account name to another.
Example:
The display name is
Daffy and Daphney Duck (10308)
when fetching thedisplayName
via thedonations
query. But thedisplayName
changes toDuck, Daffy and Daphney (10308)
when I fetch it using theContacts
query.I'm unsure if this is a backend issue or something we need to accommodate on the frontend.
Other changes I've made
If viewing the donation table outside of the contact detail page, it should show the display name. Example:
Daffy and Daphney Duck (10308)
. But if it's inside the contact, it should just display the partner account number. example:10308
.I have replaced the partner display name on the contact details header with just the partner number.
I have added the partner display name next to the partner number under the contact details tab in the partnership section.
Due to the cache updating the display name when loading the contact details query, I have moved the partnership query to a separate query and made it so it doesn't update the cache if a different display name returns.
Need to check
We need to check if the backend can ensure the partner display name can make it so the same name returns always no matter how you query (donations query or contact query). If the backend team does that. a lot of the work in this PR can be undone.
Checklist: